Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impure filters conflict with Protractor testing #72

Closed
tiagoroldao opened this issue Sep 22, 2016 · 4 comments
Closed

Impure filters conflict with Protractor testing #72

tiagoroldao opened this issue Sep 22, 2016 · 4 comments

Comments

@tiagoroldao
Copy link
Contributor

This is due to long standing timeouts being defined within the angular zone. Protractor tests timeout whenever these pipes are present on the page.

@ghost
Copy link

ghost commented Oct 2, 2016

That's interesting. Could you please take a look at this Stack Overflow question I opened a long time ago to confirm that this issue here could also be the cause for the problem I had? I originaly assumed that it may be due to http requests, but I think that I completely removed all moment pipes when excluding the http requests (because the timestamps come from a database)

If the issues I describe there matches what you found out, you are active on Stack Overflow and if you want to get some reps, feel free to answer my question linking this issue or your PR.

@tiagoroldao
Copy link
Contributor Author

I believe so. Heading to bed now, tomorrow I'll take a closer look!

@ghost
Copy link

ghost commented Oct 2, 2016

Thank you very much in advance for your time :)

@urish urish closed this as completed in #74 Oct 2, 2016
@tiagoroldao
Copy link
Contributor Author

Answered 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant