Skip to content
This repository has been archived by the owner on Mar 29, 2022. It is now read-only.

Split send payloads according to firebase's custom continuation format #115

Merged
merged 1 commit into from
Jan 30, 2018
Merged

Split send payloads according to firebase's custom continuation format #115

merged 1 commit into from
Jan 30, 2018

Conversation

andrewparmet
Copy link
Contributor

Hi Uri -

While using firebase-server we noticed that long messages being sent back from the web server were failing on the Java Firebase client. It turns out they have implemented a custom frame-chunking protocol as you can see here: https://github.com/firebase/firebase-admin-java/blob/d4a143801cf73e0de9641d29da9c5e72d1f91944/src/main/java/com/google/firebase/database/connection/WebsocketConnection.java#L124-L217. This PR sends long messages in chunks and fixes our problem.

Thanks for a great tool!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 94.822% when pulling 9c79f6c on andrewparmet:master into 0aa5f5d on urish:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 94.822% when pulling 9c79f6c on andrewparmet:master into 0aa5f5d on urish:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 94.822% when pulling 9c79f6c on andrewparmet:master into 0aa5f5d on urish:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 94.822% when pulling 9c79f6c on andrewparmet:master into 0aa5f5d on urish:master.

@coveralls
Copy link

coveralls commented Jan 30, 2018

Coverage Status

Coverage increased (+0.1%) to 94.855% when pulling d9bbfea on andrewparmet:master into 0aa5f5d on urish:master.

@urish
Copy link
Owner

urish commented Jan 30, 2018

Thank! Please see my comment in the code regarding the newline issue.

Basically, I think it will be better just to use simple string operations instead of regexp (less magic)

@andrewparmet
Copy link
Contributor Author

I don't see a comment but I think I understand the gist of it - please see my rebased commit. Thanks!

@urish
Copy link
Owner

urish commented Jan 30, 2018

Looks much better - also comes with a test now. Thank you!

@urish urish merged commit b9f8e9a into urish:master Jan 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants