Skip to content
This repository has been archived by the owner on Mar 29, 2022. It is now read-only.

add tests for priority query #14

Merged
merged 1 commit into from
Oct 23, 2015
Merged

Conversation

jamestalmage
Copy link
Contributor

Closes #12

urish added a commit that referenced this pull request Oct 23, 2015
@urish urish merged commit d10dc42 into urish:master Oct 23, 2015
@urish
Copy link
Owner

urish commented Oct 23, 2015

Thanks! I am now going over all your additions, improving support for running under windows, etc.

Hope to release this soon as 0.4.0

@urish
Copy link
Owner

urish commented Oct 24, 2015

Hi @jamestalmage, thanks again for all the amazing work!

I noticed the following code lines:

            if (normalizedPath.isPriorityPath) {
                throw new Error('I don\'t know how to listen to a priority path');
            }

Have you found any scenario that triggers this code path?

@jamestalmage
Copy link
Contributor Author

No. It certainly is possible using a raw websocket, but I don't think the firebase client ever would. It might be a good idea to have the message include reporting instructions.

If we had control / insight into the client source I might just remove it.

@urish
Copy link
Owner

urish commented Oct 24, 2015

@jamestalmage the full client source (unminified) is available here:

https://github.com/firebase/firebase-bower/blob/master/firebase-debug.js

If there is no easy way to reproduce this behavior via the client, I think it is better to remove the message...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants