Work In Progress: Split Up Index

[jamestalmage]

@urish
Don't merge yet, I just opened so you could monitor progress.
I will ping you when I am ready for a merge

[urish]

thanks @jamestalmage ! I will get 0.5.0 released soon with all the features we have so far.

Are you using firebase-server in one of your projects? How did you find out about it?

[jamestalmage]

I found out about it on the firebase blog.
I have not switched any projects from mockfirebase yet, but I have been clamoring for something like this for a long time.

[urish]

very nice to learn about that :)

0.5.0 is out!

[urish]

@jamestalmage are you still on it pal?

[jamestalmage]

Haha,
I've been off doing other stuff, but yeah, this PR needs to be finalized.

Have you taken a look? Are you OK with where I am at so far?

[urish]

Why not use ECMAScript 6 classes here?

[jamestalmage]

I am only using ECMASCRIPT 6 in the tests.

See the ignore option in test/mocha-babel.js.

I hunted around and this seemed to be the best strategy. I've been working the AVA team recently (which is pretty Babel centric testing framework), so I may have some improvements to make when I get back into this.

[urish]

Yup, overall looks really good - a lot of changes to go over though, I have written some comments and hope to go over it again sometime this weekend

[jamestalmage]

Just ping me with questions as they come up.

[jamestalmage]

Hey @urish, I'd like not to let this go much longer without a merge. I am concerned about letting it slip out of date. Have you had a chance to review?

So far I only have one note from you, and that is to not use delegates, but write it out explicitly. If that is the only change you want, I can rebase and make that change this weekend.

[urish]

Good call @jamestalmage , I am on it

[jamestalmage]

@urish - What do you want to do with this? I don't have a lot of time to spend fixing up the conflicts.

[urish]

@jamestalmage I definitely understand. I think that as long as the new code doesn't break backward comparability (I think you renamed one exported method) and all tests pass, we can get going with what you already have, and then make style fixes / improvements as we go.

Thoughts ?

[jamestalmage]

@urish - Unfortunately, I don't have time to rebase this. I will leave my branch up if anyone wants to take a crack at it.

I don't think it contained any breaking changes at the time.

[urish]

Thank you James!
On Apr 28, 2016 11:46 PM, "James Talmage" notifications@github.com wrote:

Closed #29 #29.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#29 (comment)