This repository has been archived by the owner on Mar 29, 2022. It is now read-only.
Fix security rules validation for updates #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updates can go into empty nodes: they will be created
(thus `|| {}` shortcut)
* updates can be selective, so we have to use tryPatch instead of
tryWrite
More on updates:
https://firebase.google.com/docs/database/web/read-and-write#update_specific_fields
|
I suspect the coverage drop is because of This code is a safeguard, unreachable with the current implementation (the presence of ruleset is already checked in |
|
Thanks! |
|
released as 0.11.0 |
p-salido
pushed a commit
to p/firebase-server
that referenced
this pull request
Oct 3, 2017
* origin/master: chore: release 0.11.0 chore: add package-lock.json doc: add a note about `-s` argument doc: add link to explain tryRead() issue Migrate to Targaryen 3 (urish#100) Support passing a WebSocket.Server options object to the FirebaseServer constructor (urish#101) Fix security rules validation for updates (urish#99)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(thus
|| {}shortcut)tryWrite
More on updates:
https://firebase.google.com/docs/database/web/read-and-write#update_specific_fields