This repository has been archived by the owner on Oct 5, 2021. It is now read-only.
Handle object literal types #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Let's also add at least one integration test for this? |
- Add support for simple object literals - Follows nesting rules of arrays - Remove old object test, add several integration tests for objects. Fixes mockdeep#19 Courtesy of #goodnessSquad
MadaraUchiha
force-pushed
the
parse-object-type
branch
from
f4aaf5f
to
65639aa
Compare
- Currently runs them through JSON.stringify(), might want to look at other solutions for folks who want single quotes - Also add test for that.
So that things like yarn-error.log don't get committed by accident.
urish
suggested changes
Mar 24, 2018
| @@ -3,3 +3,4 @@ dist | |||
| node_modules | |||
| .idea | |||
| assets/typewiz.psd | |||
| *.log | |||
There was a problem hiding this comment.
Is this a request for change?
src/type-collector-snippet.ts
Outdated
| } | ||
|
|
||
| return typeof value; | ||
| } | ||
|
|
||
| function getObjectTypes(obj: any, nest: number): string { | ||
| const keys = Object.keys(obj); |
There was a problem hiding this comment.
Let's sort the keys so we always get the same result for objects of the same shape.
e.g. given either of the following inputs:
Object.keys({ a: 1, b : 2 }) // ["a", "b"]
Object.keys({ b: 1, a : 2 }) // ["b", "a"]we'd like to get the same output (let's also add a test case covering this)
- Ensures more consistent results - Modify unit test and integration tests to match.
|
Thanks! |
|
Released as part of 0.7.0 |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
Add support for object types inference.
#goodnessSquad