Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SADeprecationWarning: Implicit coercion of SELECT and textual SELECT constructs into FROM clauses is deprecated; #158

Closed
kigawas opened this issue Jul 29, 2021 · 1 comment · Fixed by #159
Closed

SADeprecationWarning: Implicit coercion of SELECT and textual SELECT constructs into FROM clauses is deprecated; #158

kigawas opened this issue Jul 29, 2021 · 1 comment · Fixed by #159
Assignees
@uriyyo
Labels
bug Something isn't working

Comments

@kigawas
Copy link
Contributor

kigawas commented Jul 29, 2021

In ext/async_sqlalchemy.py:23:

SADeprecationWarning: Implicit coercion of SELECT and textual SELECT constructs into FROM clauses is deprecated; please call .subquery() on any Core select or ORM Query object in order to produce a subquery object.
    total = await session.scalar(select([func.count()]).select_from(query))
@uriyyo
Copy link
Owner

uriyyo commented Jul 29, 2021

Thanks, will take a look.

@uriyyo uriyyo self-assigned this Jul 29, 2021
@uriyyo uriyyo added the bug Something isn't working label Jul 29, 2021
@kigawas kigawas mentioned this issue Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uriyyo uriyyo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sqlalchemy subquery warning kigawas/fastapi-pagination
2 participants
@kigawas @uriyyo