Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sqlalchemy subquery warning #159

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Fix sqlalchemy subquery warning #159

merged 3 commits into from
Jul 29, 2021

Conversation

kigawas
Copy link
Contributor

@kigawas kigawas commented Jul 29, 2021

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #159 (95fbd72) into main (7ba5d02) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #159   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          407       407           
=========================================
  Hits           407       407           
Impacted Files Coverage Δ
fastapi_pagination/ext/async_sqlalchemy.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ba5d02...95fbd72. Read the comment docs.

@kigawas
Copy link
Contributor Author

kigawas commented Jul 29, 2021

query: Select should be query: Query

UPDATE:
This might need considering. Query is orm level while Select is expression level. Since we are often on expression level, Select is more semantically correct.

Maybe it's better to bump sqlalchemy to 1.4, but not in this scope.

UPDATE:
I chose to suppress the error with type: ignore.

@kigawas kigawas mentioned this pull request Jul 29, 2021
@uriyyo uriyyo added the bug Something isn't working label Jul 29, 2021
Copy link
Owner

@uriyyo uriyyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM💫

@uriyyo uriyyo merged commit a11017c into uriyyo:main Jul 29, 2021
@kigawas kigawas deleted the patch-1 branch July 29, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants