Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix type annotation #229

Merged
merged 1 commit into from
Nov 10, 2021
Merged

馃悰 Fix type annotation #229

merged 1 commit into from
Nov 10, 2021

Conversation

uriyyo
Copy link
Owner

@uriyyo uriyyo commented Nov 10, 2021

Fixes #228

@uriyyo uriyyo added the bug Something isn't working label Nov 10, 2021
@uriyyo uriyyo self-assigned this Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #229 (bcba775) into main (f49aff4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #229   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          442       441    -1     
=========================================
- Hits           442       441    -1     
Impacted Files Coverage 螖
fastapi_pagination/bases.py 100.00% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f49aff4...bcba775. Read the comment docs.

@uriyyo uriyyo merged commit ba39f1e into main Nov 10, 2021
@jtc42
Copy link

jtc42 commented Nov 10, 2021

Oh thank god, I was just heading over here to try and figure this one out. Hopefully you're able to publish the patch soon! Thanks for this.

@uriyyo
Copy link
Owner Author

uriyyo commented Nov 10, 2021

@jtc42 Version 0.9.1 has been released.

@elpablete
Copy link

Hey, thanks for this. We were going crazy trying to figure this one out!

@uriyyo
Copy link
Owner Author

uriyyo commented Nov 10, 2021

@elpablete Actually it's a pydantic issue, I have opened PR to fix this issue)

@josecsotomorales
Copy link

That was a fast fix, thank you all, love this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: typing.ClassVar[typing.Type[fastapi_pagination.bases.AbstractParams]] is not valid as type argument
4 participants