Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move opencsv to be non-shaded via liquibase #3438

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

grafjo
Copy link
Contributor

@grafjo grafjo commented Nov 25, 2022

use the upstream com.opencsv dependency instead of shipped one via liquibase. so we can update liquibase later hassle free.

for details see liquibase/liquibase#2903

@grafjo grafjo added the type: dependencies Pull requests that update a dependency file label Nov 25, 2022
@grafjo grafjo added this to the 4.56.0 milestone Nov 25, 2022
@grafjo grafjo marked this pull request as ready for review November 25, 2022 15:06
@github-actions github-actions bot added the status: planned This issue is planned in a milestone and won't be touched by stale bot. label Nov 25, 2022
@grafjo grafjo force-pushed the use-dedicated-opencsv-dependency branch from 29ec06a to 539fbf1 Compare November 25, 2022 15:15
pom.xml Outdated
@@ -34,6 +35,16 @@
<tag>HEAD</tag>
</scm>

<dependencyManagement>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warum via dependency management und nicht direkt?

@derTobsch derTobsch modified the milestones: 4.56.0, 4.55.0 Nov 25, 2022
@github-actions github-actions bot added status: new Initial state for every issue / pullrequest status: planned This issue is planned in a milestone and won't be touched by stale bot. and removed status: planned This issue is planned in a milestone and won't be touched by stale bot. status: new Initial state for every issue / pullrequest labels Nov 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@derTobsch derTobsch merged commit 77feae2 into main Nov 25, 2022
@derTobsch derTobsch deleted the use-dedicated-opencsv-dependency branch November 25, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot. type: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants