[1.26] Mention pool size when discarding connections (#2497)

urllib3 · Dec 7, 2021 · 06406c5 · 06406c5
1 parent 80531c0
commit 06406c5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/urllib3/connectionpool.py b/src/urllib3/connectionpool.py
@@ -302,8 +302,11 @@ def _put_conn(self, conn):
             pass
         except queue.Full:
             # This should never happen if self.block == True
-            log.warning("Connection pool is full, discarding connection: %s", self.host)
-
+            log.warning(
+                "Connection pool is full, discarding connection: %s. Connection pool size: %s",
+                self.host,
+                self.pool.qsize(),
+            )
         # Connection never got put back into the pool, close it.
         if conn:
             conn.close()

diff --git a/test/test_connectionpool.py b/test/test_connectionpool.py
@@ -225,7 +225,7 @@ def test_max_connections(self):
 
             assert pool.num_connections == 1
 
-    def test_pool_edgecases(self):
+    def test_pool_edgecases(self, caplog):
         with HTTPConnectionPool(host="localhost", maxsize=1, block=False) as pool:
             conn1 = pool._get_conn()
             conn2 = pool._get_conn()  # New because block=False
@@ -237,6 +237,8 @@ def test_pool_edgecases(self):
             assert conn2 != pool._get_conn()
 
             assert pool.num_connections == 3
+            assert "Connection pool is full, discarding connection" in caplog.text
+            assert "Connection pool size: 1" in caplog.text
 
     def test_exception_str(self):
         assert (