Fix flaky test by setting longer connect timeout

This test is not setting a connection timeout, so the connect timeout should be long, not short.
urllib3 · Apr 11, 2020 · 2ec3438 · 2ec3438
1 parent 262ac6b
commit 2ec3438
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/test/test_proxymanager.py b/test/test_proxymanager.py
@@ -2,7 +2,6 @@
 
 from .port_helpers import find_unused_port
 from urllib3.poolmanager import ProxyManager
-from urllib3.util.url import parse_url
 from urllib3.util.retry import Retry
 from urllib3.exceptions import (
     MaxRetryError,

diff --git a/test/with_dummyserver/test_socketlevel.py b/test/with_dummyserver/test_socketlevel.py
@@ -496,7 +496,7 @@ def socket_handler(listener):
 
         try:
             self._start_server(socket_handler)
-            t = Timeout(connect=SHORT_TIMEOUT, read=LONG_TIMEOUT)
+            t = Timeout(connect=LONG_TIMEOUT, read=LONG_TIMEOUT)
             with HTTPConnectionPool(self.host, self.port, timeout=t) as pool:
                 response = pool.request("GET", "/", retries=1)
                 assert response.status == 200