Skip to content

Commit

Permalink
Switch to deque LifoQueue
Browse files Browse the repository at this point in the history
  • Loading branch information
sethmlarson committed Apr 3, 2018
1 parent 89f4a9d commit 8e83725
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 6 deletions.
8 changes: 2 additions & 6 deletions urllib3/connectionpool.py
Expand Up @@ -41,11 +41,7 @@
from .util.retry import Retry
from .util.timeout import Timeout
from .util.url import get_host, Url


if six.PY2:
# Queue is imported for side effects on MS Windows
import Queue as _unused_module_Queue # noqa: F401
from .util.queue import LifoQueue

xrange = six.moves.xrange

Expand All @@ -62,7 +58,7 @@ class ConnectionPool(object):
"""

scheme = None
QueueCls = queue.LifoQueue
QueueCls = LifoQueue

def __init__(self, host, port=None):
if not host:
Expand Down
21 changes: 21 additions & 0 deletions urllib3/util/queue.py
@@ -0,0 +1,21 @@
import collections
from ..packages import six
from ..packages.six.moves import queue

if six.PY2:
# Queue is imported for side effects on MS Windows. See issue #229.
import Queue as _unused_module_Queue # noqa: F401


class LifoQueue(queue.Queue):
def _init(self, _):
self.queue = collections.deque()

def _qsize(self, len=len):
return len(self.queue)

def _put(self, item):
self.queue.append(item)

def _get(self):
return self.queue.pop()

0 comments on commit 8e83725

Please sign in to comment.