-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URLs without // don't parse correctly #1529
Comments
Hm, what should that parse to? |
Per RFC3986 should be Scheme: mailto We have the same problem with |
@sethmlarson I think you may be confused.
|
rfc3986 has specific tests covering this, by the way, https://github.com/python-hyper/rfc3986/blob/0d82fee4b21482ae6cf4337dc8216e4d1ce507ea/tests/test_uri.py#L13 You can check everywhere that that particular fixture is used. |
You're right @sigmavirus24, our scheme detecting regex is wrong but the above example shouldn't parse that way. Thanks for correcting me before I go too off the rails. :) |
It's unfortunate that I know the RFC as well as I do, but I guess also inevitable. |
URLs like:
mailto:johndoe@example.com
don't parse correctly due to our logic on when to add a scheme delimeter to a URL.The text was updated successfully, but these errors were encountered: