Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for correct h2 version range #3290

Open
sethmlarson opened this issue Jan 19, 2024 · 1 comment · May be fixed by #3402
Open

Add check for correct h2 version range #3290

sethmlarson opened this issue Jan 19, 2024 · 1 comment · May be fixed by #3402
Labels
Contributor Friendly ♥
Milestone
HTTP/2

Comments

@sethmlarson
Copy link
Member

Similar to our other third-party package support, we should be checking which version of h2 is installed and raise an error in the case we get an unsupported version. We know that h2 uses semver, so we can check the major version is in our desired range.
@sethmlarson sethmlarson added this to the HTTP/2 milestone Jan 19, 2024
ktpa added a commit to ktpa/urllib3 that referenced this issue Jun 10, 2024
@ktpa
urllib3#3290 add h2 version check
36535c5
ktpa added a commit to ktpa/urllib3 that referenced this issue Jun 10, 2024
@ktpa
Add h2 tests for urllib3#3290
cbb168a
ktpa added a commit to ktpa/urllib3 that referenced this issue Jun 10, 2024
@ktpa
Add changelog content for urllib3#3290
aec16a8
@ktpa ktpa linked a pull request Jun 10, 2024 that will close this issue
Open
@ktpa
Copy link

ktpa commented Jun 10, 2024

@sethmlarson Took the freedom to create the check. Looking forward to some feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Contributor Friendly ♥
Projects
None yet
Milestone
HTTP/2
Development

Successfully merging a pull request may close this issue.

Add check for correct h2 version range ktpa/urllib3
2 participants
@sethmlarson @ktpa