Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early-out ipv6 checks when running on App Engine #1450

Merged
merged 1 commit into from Oct 5, 2018

Conversation

@theacodes
Copy link
Member

@theacodes theacodes commented Oct 5, 2018

Closes #1446

@theacodes theacodes requested a review from sethmlarson Oct 5, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Oct 5, 2018

Codecov Report

Merging #1450 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1450   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          21      22    +1     
  Lines        1811    1823   +12     
======================================
+ Hits         1811    1823   +12
Impacted Files Coverage Δ
src/urllib3/contrib/_appengine_environ.py 100% <100%> (ø)
src/urllib3/util/connection.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b3636f...0140753. Read the comment docs.

@sethmlarson sethmlarson merged commit 977c9ff into urllib3:master Oct 5, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.