Normalize setup.py and setup.cfg dependencies for extras #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theacodes
approved these changes
Dec 10, 2018
Codecov Report
@@ Coverage Diff @@
## master #1497 +/- ##
=======================================
Coverage 66.84% 66.84%
=======================================
Files 22 22
Lines 2760 2760
=======================================
Hits 1845 1845
Misses 915 915Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to install these dependencies because our upstream expects pyOpenSSL support to be available on all platforms when installed with
urllib3[secure].Closes #1460.