Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous test improvements #1554

Merged
merged 4 commits into from
Mar 23, 2019
Merged

Miscellaneous test improvements #1554

merged 4 commits into from
Mar 23, 2019

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Mar 19, 2019 •
edited
Loading

  • Stop excluding various Python 3 branches
  • Bump timeouts to help with CI flakiness
  • Ensure test_create_connection_timeout can be run alone

@pquentin
Copy link
Member Author

I think we need to increase the timeout here: https://ci.appveyor.com/project/urllib3/urllib3/builds/23181492/job/7pxif8ivn6t9igpd

@pquentin
Copy link
Member Author

pquentin commented Mar 19, 2019 •
edited
Loading

Those timeouts happen all the time on AppVeyor and are a real problem. Here are examples from the last 3 months:

The brotli changes made things worse, because we now run twice as many builds.

Should we increase the timeout from 0.001 to 0.010? Switch to Azure Pipelines? Something else?

Anyway, retrying.

@pquentin pquentin closed this Mar 19, 2019
@pquentin pquentin reopened this Mar 19, 2019
@codecov-io
Copy link

codecov-io commented Mar 19, 2019 •
edited
Loading

Codecov Report

Merging #1554 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1554   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          22      22           
  Lines        1824    1840   +16     
======================================
+ Hits         1824    1840   +16
Impacted Files Coverage Δ
src/urllib3/util/timeout.py 100% <100%> (ø) ⬆️
src/urllib3/response.py 100% <100%> (ø) ⬆️
src/urllib3/connectionpool.py 100% <100%> (ø) ⬆️
src/urllib3/connection.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe558b...cac3028. Read the comment docs.

@pquentin
Copy link
Member Author

Now TestSocketClosing.test_connection_closed_on_read_timeout_preload_false failed in https://travis-ci.org/urllib3/urllib3/jobs/508345777. Bumping that timeout too.

@pquentin
test: bump all read timeouts from 1ms to 10ms
f102a6b 
We regularly hit the old timeouts on AppVeyor CI. The test suite takes
between 30 to 40 secondes to run on my macOS machine with and without
this change: if there's a speed difference, it's lost in the noise.
@pquentin
test: bump timeout for success path
8072d86 
The read timeout was reached on macOS CI.
@pquentin pquentin changed the title Stop excluding Python 3 paths from coverage Miscellaneous test improvements Mar 19, 2019
sethmlarson
sethmlarson approved these changes Mar 23, 2019
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@sethmlarson sethmlarson merged commit edfd345 into urllib3:master Mar 23, 2019
@pquentin
Copy link
Member Author

Thank you for the review!

@kaylangan kaylangan mentioned this pull request Mar 27, 2019
Closed
@pquentin pquentin mentioned this pull request Mar 28, 2019
Merged
@pquentin pquentin deleted the py3-coverage branch August 19, 2019 09:27
@pquentin pquentin mentioned this pull request Oct 11, 2019
Closed
SuperSandro2000 added a commit to SuperSandro2000/nixpkgs that referenced this pull request Mar 13, 2021
@SuperSandro2000
pythonPackages.urllib3: disable failing test
f942c6c 
According to upstream the tests can be flaky.
If others are failing also add them or disable tests.

urllib3/urllib3#1554 (comment)
Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
@pquentin @sethmlarson
Improve CI stability for timeouts and branch coverage (urllib3#1554)
2640746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pquentin @codecov-io @sethmlarson