Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 config file for ignoring black styles linting error. #1631

Merged
merged 4 commits into from
Jun 4, 2019
Merged

Add flake8 config file for ignoring black styles linting error. #1631

merged 4 commits into from
Jun 4, 2019

Conversation

RatanShreshtha
Copy link
Contributor

Added .flake8 file copied mainly from https://github.com/theacodes/nox/blob/master/.flake8 and removed the # noqa.

@haikuginger
Copy link
Contributor

Could you rebase this specific change on master rather than on the "remove addCleanup" branch? Thanks!

@RatanShreshtha
Copy link
Contributor Author

I have updated the PR.

@sethmlarson
Copy link
Member

Looks like black is catching a linting issue?

@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #1631 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1631      +/-   ##
==========================================
- Coverage   99.47%   99.47%   -0.01%     
==========================================
  Files          22       22              
  Lines        1915     1900      -15     
==========================================
- Hits         1905     1890      -15     
  Misses         10       10
Impacted Files Coverage Δ
src/urllib3/connection.py 93.75% <ø> (-0.09%) ⬇️
src/urllib3/util/url.py 99.1% <100%> (-0.04%) ⬇️
src/urllib3/util/timeout.py 100% <0%> (ø) ⬆️
src/urllib3/response.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c8275...0a2a39e. Read the comment docs.

@pquentin
Copy link
Member

pquentin commented Jun 4, 2019

Can we expand the configuration in setup.cfg instead of creating a new file?

@RatanShreshtha
Copy link
Contributor Author

Updated the PR and added the flake8 ignore rules in setup.cfg

@sethmlarson sethmlarson closed this Jun 4, 2019
@sethmlarson sethmlarson reopened this Jun 4, 2019
@sethmlarson sethmlarson merged commit f6d5b4b into urllib3:master Jun 4, 2019
@sethmlarson
Copy link
Member

Thanks for this! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants