-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flake8 config file for ignoring black styles linting error. #1631
Add flake8 config file for ignoring black styles linting error. #1631
Conversation
Could you rebase this specific change on master rather than on the "remove addCleanup" branch? Thanks! |
I have updated the PR. |
Looks like black is catching a linting issue? |
Codecov Report
@@ Coverage Diff @@
## master #1631 +/- ##
==========================================
- Coverage 99.47% 99.47% -0.01%
==========================================
Files 22 22
Lines 1915 1900 -15
==========================================
- Hits 1905 1890 -15
Misses 10 10
Continue to review full report at Codecov.
|
Can we expand the configuration in setup.cfg instead of creating a new file? |
Updated the PR and added the flake8 ignore rules in setup.cfg |
Thanks for this! :) |
Added .flake8 file copied mainly from https://github.com/theacodes/nox/blob/master/.flake8 and removed the # noqa.