test: remove unneeded new lines after with statements #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently switched to using context managers in tests, but the extra indentation means that the newlines that were there before are no longer needed.
Codecov Report
@@ Coverage Diff @@
## master #1702 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 22 22
Lines 2006 2006
=======================================
Hits 2001 2001
Misses 5 5Continue to review full report at Codecov.
|
sethmlarson
approved these changes
Oct 1, 2019
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
We recently switched to using context managers in tests, but the extra indentation means that the newlines that were there before are no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently switched to using context managers in tests, but the extra
indentation means that the newlines that were there before are no longer
needed.
(And this is how I did it in the bleach-spike branch, so it should help with merges.)
As always, you don't have to agree that this is a valid change!