Fix macOS and Python 2.7 build #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Migrating to GitHub Actions sounds great! I want this project to be in a post-Travis world. :) |
sethmlarson
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macOS + Python 2.7 build currently fails because the "coverage" entry point is installed outside of PATH. I think I got hit by this when working on the macOS tests, and added a workaround in _travis/run.sh.
The workaround stopped being necessary at some point, which is why we did not notice when the switch to Nox broke it. Now there's a bug in virtualenv's rewrite, so we need the workaround again. But this time we know where the bug is, and will be able to remove the workaround when virtualenv fixes this issue.
By the way, I found out about https://github.com/MacPython/terryfy today, which could allow us to remove some of the boilerplate. But I think I'd rather migrate to GitHub Actions that to continue investing time in our Travis macOS builds.