Revert "Add context to find_unused_port (#1837)" #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a9508d8.
|
The build failure is fixed in #1844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a9508d8.
For some reason, this commit was making the tests really, really slow on macOS. For example,
test_proxy_connect_retrywent from nearly instant to 25 seconds on my computer. As a result, macOS tests in CI went from ~3 minutes to ~8 minutes. I thought this was because of GitHub Actions, but in fact the above commit was the last where tests ran on macOS. GitHub Actions is fine.Sorry about that, @hodbn, but practicality beats purity here.