Disallow pyOpenSSL from using SSLv2 and SSLv3 #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
reviewed
Feb 12, 2022
src/urllib3/contrib/pyopenssl.py
Outdated
| *not* do certificate checking; you need to do additional work to validate | ||
| certificates yourself. | ||
| Module for using pyOpenSSL as a TLS backend. This module was relevant before | ||
| the standard library ``ssl`` module supported SNI. Nowadays all supported |
There was a problem hiding this comment.
Only note is “Nowadays” is a bit colloquial for non-native English speakers. Maybe you’re going for that Midwest flare though 😉
There was a problem hiding this comment.
Haha, good point! I'll change this.
There was a problem hiding this comment.
Although our docs are seriously lacking in Midwest flare, maybe need to add a section on some recipes like tater tot hotdish to make up for it 😉
nateprewitt
previously approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2233