Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a workflow for publishing to PyPI #2666

Merged
merged 2 commits into from
Jul 3, 2022
Merged

Create a workflow for publishing to PyPI #2666

merged 2 commits into from
Jul 3, 2022

Conversation

sethmlarson
Copy link
Member

@sethmlarson sethmlarson commented Jul 1, 2022 •
edited
Loading

Security measures in place:

  • Added the .github/workflows directory to CODEOWNERS
  • Tags for the * pattern are protected to maintain/admin privileges
  • The publish environment requires a review from @shazow, @pquentin, or I to execute
  • The publish environment has a PYPI_TOKEN configured for only the urllib3 package
  • Used commits instead of tags for GitHub actions we're using within the workflow

I've added @pquentin to our CODEOWNERS reviewers because there isn't any additional risk as you're already a release manager now with reviewer privileges of the publish environment and you can help with the reviewing load to CODEOWNERS protected files.

@sethmlarson sethmlarson requested a review from shazow as a code owner July 1, 2022 16:44
@sethmlarson sethmlarson added the Skip Changelog Pull requests that don't require a changelog entry label Jul 1, 2022
@sethmlarson sethmlarson requested a review from pquentin July 1, 2022 18:53
shazow
shazow previously approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@shazow shazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test the workflow, but the rest looks good!

pquentin
pquentin approved these changes Jul 3, 2022
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing this! Looks good to me.

@sethmlarson sethmlarson merged commit dbdef81 into urllib3:main Jul 3, 2022
@sethmlarson sethmlarson deleted the publish-action branch July 3, 2022 13:19
@rht rht mentioned this pull request Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

@shazow shazow shazow left review comments

Assignees
No one assigned
Labels
Skip Changelog Pull requests that don't require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sethmlarson @shazow @pquentin