Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop considering LibreSSL for HAS_NEVER_CHECK_COMMON_NAME #2783

Merged
merged 3 commits into from Nov 12, 2022
Merged

Stop considering LibreSSL for HAS_NEVER_CHECK_COMMON_NAME #2783

merged 3 commits into from Nov 12, 2022
+15 −34

Conversation

pquentin
Copy link
Member

We don't support LibreSSL at all since #2705.

@pquentin pquentin added the Skip Changelog Pull requests that don't require a changelog entry label Nov 10, 2022
sethmlarson
sethmlarson approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we be doing something to warn users about using Python compiled with non-OpenSSL? Warning or error?

@sethmlarson
Copy link
Member

I think since we're documenting this in the changelog we can just merge this.

@sethmlarson sethmlarson merged commit 9763f09 into urllib3:main Nov 12, 2022
@pquentin
Copy link
Member Author

We actually raise an ImportError in urllib3/__init__.py so this was unreachable code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
Skip Changelog Pull requests that don't require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pquentin @sethmlarson