Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise ResourceWarnings as errors #2842

Merged
merged 49 commits into from
Dec 31, 2023
Merged

raise ResourceWarnings as errors #2842

merged 49 commits into from
Dec 31, 2023

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Nov 30, 2022 •
edited

fixes #2970

@graingert graingert force-pushed the fix-resource-warnings branch 2 times, most recently from fdefe53 to 5ab8ebc Compare November 30, 2022 15:30
@sethmlarson sethmlarson added the Skip Changelog Pull requests that don't require a changelog entry label Dec 13, 2022
@graingert graingert marked this pull request as ready for review April 7, 2023 22:41
graingert
graingert commented Apr 12, 2023
View reviewed changes
src/urllib3/connection.py Outdated Show resolved Hide resolved
This was referenced Apr 18, 2023
Closed
Merged
graingert
graingert commented Dec 18, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
sethmlarson
sethmlarson previously approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this PR in its current state, @graingert did you want this merged before all ResourceWarnings are fixed or are you okay with it happening whenever?

You may need to add the resource warning skip to the Emscripten tests as well, unless the issue is fixable on our side?

@graingert
Copy link
Contributor Author

@sethmlarson looks like it's fixable on the urllib3 side, but I raised it here just in case pallets/quart#303

@graingert
Copy link
Contributor Author

@sethmlarson it would be great to get this merged, I think #3240 is the last bit that needs merging first as that was issuing a ResourceWarning

@graingert graingert closed this Dec 31, 2023
@graingert graingert reopened this Dec 31, 2023
@graingert
Copy link
Contributor Author

@sethmlarson I think this is ready to go now?

sethmlarson
sethmlarson approved these changes Dec 31, 2023
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much @graingert!

@sethmlarson sethmlarson merged commit 56e606d into urllib3:main Dec 31, 2023
65 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

@pquentin pquentin Awaiting requested review from pquentin pquentin is a code owner

@shazow shazow Awaiting requested review from shazow shazow is a code owner

@illia-v illia-v Awaiting requested review from illia-v illia-v is a code owner

Assignees
No one assigned
Labels
Skip Changelog Pull requests that don't require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pyopenssl.WrappedSocket and secureransport.WrappedSocket close implementation broken
2 participants
@graingert @sethmlarson