Make BytesQueueBuffer.get_all more memory efficient
#3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illia-v
added
the
Skip Changelog
pquentin
reviewed
Dec 19, 2023
Comment on lines
-294
to
+296
| result = b"".join(buffer) | ||
| buffer.clear() | ||
| ret = io.BytesIO() | ||
| ret.writelines(buffer.popleft() for _ in range(len(buffer))) | ||
| result = ret.getvalue() |
There was a problem hiding this comment.
Were you able to measure the memory gain? I would expect str.join to do exactly that under the hood. If it made a difference, the surely we could lower some of the pytest.mark.limit_memory decorators?
There was a problem hiding this comment.
With b"".join(buffer) there was a moment when result took memory for all the data, but buffer has not been cleared yet and it took the same amount of memory additionally. So test_memory_usage reported around 20 MB instead of around 12 MB (5 * 2 MiB chunks + 2 MiB for overhead from the last chunk.)
There was a problem hiding this comment.
Makes sense, thanks. I guess I was surprised that no other test showed a memory usage improvement!
|
@pquentin thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds memray tests for functionality added in #3186 and improves memory efficiency of
BytesQueueBuffer.get_all.