Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Arthur Grunseid to contributors. #374

Merged
merged 2 commits into from Apr 16, 2014
+4 −1
Merged

Add Arthur Grunseid to contributors. #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8946ee3
Add Arthur Grunseid to contributors.
gruns Apr 16, 2014
f126fd5
Add Python 2.7+ version comment to achieve 100% Python 2.6 test cover…
gruns Apr 16, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions CONTRIBUTORS.txt
View file
Open in desktop
Expand Up @@ -114,5 +114,8 @@ In chronological order:
* Tahia Khan <http://tahia.tk/>
* Added Timeout examples in docs

* Arthur Grunseid <http://grunseid.com>
* source_address support and tests (with https://github.com/bui)

* [Your name or handle] <[email or website]>
* [Brief summary of your changes]
2 changes: 1 addition & 1 deletion urllib3/connection.py
View file
Open in desktop
Expand Up @@ -83,7 +83,7 @@ def _new_conn(self):
:return: a new socket connection
"""
extra_args = []
if self.source_address:
if self.source_address: # Python 2.7+
extra_args.append(self.source_address)

conn = socket.create_connection(
Expand Down