Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New request logic for PoolManager: strips scheme/host from request, better redirect #85

Merged
merged 3 commits into from
Jul 18, 2012

Conversation

shazow
Copy link
Member

@shazow shazow commented Jul 1, 2012

Using the new parse_url, yay.

Fixes #8 and #11.

* Built-in redirect will switch method to 'GET' if status code is 303. (Issue #11)
* ``urllib3.PoolManager`` strips the scheme and host before sending the request uri. (Issue #8)
@shazow
Copy link
Member Author

shazow commented Jul 1, 2012

Ping #8 and #11.

@shazow
Copy link
Member Author

shazow commented Jul 1, 2012

Hrm tests fail on py32, need to add fixen.

@schlamar
Copy link
Contributor

@shazow There is still something wrong with redirects, see #84.

shazow added a commit that referenced this pull request Jul 18, 2012
New request logic for PoolManager: strips scheme/host from request, better redirect.
@shazow shazow merged commit 611dfa0 into master Jul 18, 2012
@schlamar schlamar mentioned this pull request Jul 19, 2012
@shazow shazow deleted the only-request-uri branch June 25, 2014 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheme and host erroneously passed to HTTPConnection request method
2 participants