Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation branch #33

Merged
merged 1 commit into from Mar 20, 2020
Merged

add documentation branch #33

merged 1 commit into from Mar 20, 2020

Conversation

SuperKogito
Copy link
Member

Sphinx generated docs

@vsoch
Copy link
Collaborator

vsoch commented Mar 20, 2020

Will this be done on an automated build, for a release? Just manually updated for now?

@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #33 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   86.37%   86.37%           
=======================================
  Files           7        7           
  Lines         301      301           
=======================================
  Hits          260      260           
  Misses         41       41           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78265c7...78a71f0. Read the comment docs.

@SuperKogito
Copy link
Member Author

Well my idea is to host these on readthedocs.com and they will be automatically generated/updated when the code is changed. I don't think these docs are very useful for users atm unless we add more use cases and examples to them. However, for now the docs will serve as a guide for us (developers) and any contributors/ users who need to know more about the code. what do you think about it?

@vsoch
Copy link
Collaborator

vsoch commented Mar 20, 2020

I've had best luck with hosting docs alongside code, that way they are versioned with it, and I've also had general / weird build issues with readthedocs that are hard to debug. If you feel strongly about it, it's definitely commonly done, but I would advocate for keeping the documentation under docs/ alongside the code (so it's versioned and released with it) and then having an automated build process to update them on some event (release, etc.)

@SuperKogito SuperKogito merged commit 114444b into urlstechie:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants