Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 32 proper refactor #33

Merged
merged 16 commits into from Jun 7, 2022
Merged

Issue 32 proper refactor #33

merged 16 commits into from Jun 7, 2022

Conversation

urmichm
Copy link
Owner

@urmichm urmichm commented Jun 5, 2022

No description provided.

@urmichm urmichm self-assigned this Jun 5, 2022
@urmichm urmichm linked an issue Jun 5, 2022 that may be closed by this pull request
@urmichm
Copy link
Owner Author

urmichm commented Jun 5, 2022

Diana class to be removed

@urmichm
Copy link
Owner Author

urmichm commented Jun 7, 2022

In a separate issue, think of adding a common class for :

  • TextSearchContainer
  • NearbySearchContainer
  • FindPlaceContainer

All containers have:

  • htmlAttributions (except FindPlaceContainer, but could be made nullable)
  • results ( aka candidates in FindPlaceContainer, but we can use @JSON(name="candidates") to overcome this)
  • status
  • errorMessage
  • infoMessages
  • nextPageToken (except FindPlaceContainer, but could be made nullable)

A single container class would make it possible to make an abstract class with abstract call() method for all PlaceSearch classes

@urmichm urmichm merged commit dfedb02 into main Jun 7, 2022
@urmichm urmichm mentioned this pull request Jun 7, 2022
@urmichm urmichm deleted the issue-32-proper-refactor branch June 7, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proper refactor
1 participant