fix(gradle-build): fixes an issue where the android build fails if there is no keystore file #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere is no keystore file
|
Oh, that's great. Thanks for the PR! I'll merge it. I'll also open some issues soon so you can help out. Thanks for stopping by! I'm glad you liked the project. |
|
@stevenviar You can work on the currently open issues if you like. I can't think of any more to add at the moment. |
|
@urmilshroff sounds good, I'll see what I can do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the build was failing when trying to run this project in release mode for android as advised in the readme. I also noticed you had this same problem yourself (#7) and it was resolved when you restored your keystore file.
I added a conditional statement that allows someone that's just cloned the project to be able to run it in release mode (using the default
signingConfigs.debug) while still allowing you to use your signed version.Love the project by the way! Haven't had much of a chance to play with it yet, but I'd love to offer any help I can.