Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reminders are very broken #4

Closed
urmilshroff opened this issue Jun 25, 2019 · 3 comments
Closed

Reminders are very broken #4

urmilshroff opened this issue Jun 25, 2019 · 3 comments
Assignees
@urmilshroff
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@urmilshroff
Copy link
Owner

TODO:

  • Need to display reminder time in GoalsPage.
  • Need to add option to edit reminders in EditPage.
  • Need to allow multiple reminder notifications (newer ones overwrite already existing ones in the notification shade).
  • Need to fix time when reminders are displayed.

TL;DR:
The entire reminders feature is pretty broken, and the code is kind of a mess. This is my first proper Flutter app and I don't really know what I'm doing.
@urmilshroff urmilshroff added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 25, 2019
@urmilshroff urmilshroff self-assigned this Jun 25, 2019
@ghaith96
Copy link
Contributor

ghaith96 commented Aug 5, 2019

Hey, this is very interesting, i would like to give it a shot if possible 😀.

@urmilshroff
Copy link
Owner Author

@ghaith96 Sure! I don't have much time to work on this project due to college work, but I'd love it if someone could fix it. You can fork the repo and send me a pull request with the fixes😁

@ghaith96 ghaith96 mentioned this issue Aug 11, 2019
Merged
@urmilshroff
Copy link
Owner Author

Hey @ghaith96! I've reviewed all of your PRs and everything's working great. Thank you so much!

I wanted to let you know that I've made some minor changes, and will be publishing the update on the Play Store in a couple of hours from now, so you should see it live soon.

Once again, thanks for all the help! Maybe you could check out my other Flutter app, Dashboard Reborn and help with some of those issues, if you'd like to😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@urmilshroff urmilshroff

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@urmilshroff @ghaith96