Skip to content

Commit

Permalink
Merge pull request #9 from urmilshroff/effective-dart
Browse files Browse the repository at this point in the history
Implemented Effective Dart linting
  • Loading branch information
urmilshroff committed Sep 7, 2020
2 parents 4773e4f + dc0009c commit d19345f
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 1 deletion.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<a href='https://github.com/urmilshroff/muze/network'> <img alt='Forks' src='https://img.shields.io/github/forks/urmilshroff/muze'> </a>
<a href='https://github.com/urmilshroff/muze/issues'> <img alt='Issues' src='https://img.shields.io/github/issues/urmilshroff/muze'> </a>
<a href='https://github.com/urmilshroff/muze/actions?query=workflow%3ABuild'> <img alt='Build status' src='https://img.shields.io/github/workflow/status/urmilshroff/muze/Build'> </a>
<a href='https://pub.dev/packages/effective_dart'> <img alt='Style' src='https://img.shields.io/badge/style-effective_dart-40c4ff.svg'> </a>
<a href='https://github.com/urmilshroff/muze/blob/main/LICENSE'> <img alt='License' src='https://img.shields.io/github/license/urmilshroff/muze'> </a>
</p>

Expand Down
15 changes: 15 additions & 0 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
include:
- package:pedantic/analysis_options.yaml
- package:effective_dart/analysis_options.yaml

linter:
rules:
- annotate_overrides
- await_only_futures
- camel_case_types
- cancel_subscriptions
- close_sinks
- comment_references
- constant_identifier_names
- control_flow_in_finally
- empty_statements
9 changes: 8 additions & 1 deletion pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,13 @@ packages:
url: "https://pub.dartlang.org"
source: hosted
version: "0.5.0"
effective_dart:
dependency: "direct dev"
description:
name: effective_dart
url: "https://pub.dartlang.org"
source: hosted
version: "1.2.4"
fab_circular_menu:
dependency: "direct main"
description:
Expand Down Expand Up @@ -444,7 +451,7 @@ packages:
source: hosted
version: "1.0.3"
pedantic:
dependency: transitive
dependency: "direct dev"
description:
name: pedantic
url: "https://pub.dartlang.org"
Expand Down
2 changes: 2 additions & 0 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,11 @@ dev_dependencies:
flutter_test:
sdk: flutter
# build_runner: ^1.10.2
effective_dart: ^1.2.4
flutter_launcher_icons: ^0.7.5
flutter_native_splash: ^0.1.9
hive_generator: ^0.7.1
pedantic: ^1.9.2

flutter_icons:
android: 'launcher_icon'
Expand Down

0 comments on commit d19345f

Please sign in to comment.