Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently the error is sticked to previous phrase.
Like
Should I also send patch to gcc or libcody is eventually updated from here?
Also I've naively fixed an ICE in module.cc (
void module_state::set_filename (const Cody::Packet &packet)
):If we do not fail here, tons of ICEs come later.
There can be communication error, so we do not get same number of packets sent about querying modules.
The following function
iterates over responses and does not check for
r_iter == response.end()