Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing feedparser classes #117

Closed
moorepants opened this issue Sep 18, 2020 · 9 comments
Closed

Missing feedparser classes #117

moorepants opened this issue Sep 18, 2020 · 9 comments

Comments

@moorepants
Copy link

General

If at all possible, provide a MVCE. If this is inappropriate (e.g. it's obviously a bug), just fill in the below:

Platform: Ubuntu 20.04
Python version: 3.7
Pyzotero version: 1.4.16

Problem description

  • What were you trying to do?
    • What API call did it involve
    • What error was raised?

I tried the calling Zotero() and get this error:

~/miniconda/lib/python3.7/site-packages/pyzotero/zotero.py in <module>
    103 
    104 # Override feedparser's buggy isBase64 method until they fix it
--> 105 feedparser._FeedParserMixin._isBase64 = ib64_patched
    106 
    107 

AttributeError: module 'feedparser' has no attribute '_FeedParserMixin'

If possible, paste the full traceback in a code block below, and fill in the summary

Traceback
code goes here, indented with four spaces
@moorepants
Copy link
Author

Note that his error is not present if feedparser's version is < 6. It is likely a breaking change feedparser made in version 6.

@urschrei
Copy link
Owner

Did you manually install Feedparser 6.0.1? Pyzotero's Feedparser version is pinned to 5.2.1 as the 6.x series isn't compatible with Python 2 or Python 3 versions below 3.6…

@moorepants
Copy link
Author

It looks like the pyzotero conda feedstock is >=5.2.1 not ==5.2.1. Should it be >=5.2.1,<6 ?

@urschrei
Copy link
Owner

Yep, there's the problem.

@urschrei
Copy link
Owner

Just pushed the v1.4.18 tag and release to PyPI to fix this. The bot should pick it up…

@moorepants
Copy link
Author

Ok, the bot won't correct the dependencies in the meta.yaml file though. That still has to be done manually.

@urschrei
Copy link
Owner

OK, edited the bot PR to use feedparser <6.0.0, and merged.

@moorepants
Copy link
Author

I made a comment on the PR. I think you want to set lower and upper bounds.

@urschrei
Copy link
Owner

Ah, wasn't sure whether I could do that. Sorry for jumping the gun! Opened a fresh PR at: conda-forge/pyzotero-feedstock#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants