Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the version in the header is always a string #60

Closed
wants to merge 1 commit into from
Closed

Make sure that the version in the header is always a string #60

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 22, 2016

the requests module does no longer accept integer for header values (see kennethreitz/requests#11). Make sure that the version is always a string. Triggered by jbaiter/zotero-cli.

the `requests` module does no longer accept integer for header values (see kennethreitz/requests#11). Make sure that the version is always a string. Triggered by jbaiter/zotero-cli.
@coveralls
Copy link

coveralls commented Aug 22, 2016

Coverage Status

Changes Unknown when pulling 4fa30fe on mrbiber:no_integer_headers_allowed into * on urschrei:master*.

@urschrei
Copy link
Owner

  • The Requests issue you linked to has no information about the use of integers for header values.
  • Is there a failure somewhere which has prompted this PR? I don't know what "triggered by jbaiter/zotero-cli" means
  • Please open pull requests against the dev branch, as per CONTRIBUTING

@ghost ghost closed this Aug 23, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants