Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that the modified header value is always a string #61

Merged
merged 1 commit into from Aug 23, 2016
Merged

Make sure that the modified header value is always a string #61

merged 1 commit into from Aug 23, 2016

Conversation

ghost
Copy link

@ghost ghost commented Aug 23, 2016

  • As I found out while using jbaiter/zotero-cli, it is possible to create a Zotero API request using this library that results in the creation of a "if-unmodified-since" header with an integer value that is then handed over to the requests module.
  • See kennethreitz/requests#3477 for a change in that module that causes integer values to create an error
  • This pull request makes sure that the value of the "if-unmodified-since" header field is always a string.

@coveralls
Copy link

coveralls commented Aug 23, 2016 •
edited

Coverage Status

Coverage remained the same at 40.924% when pulling aa537d7 on mrbiber:no_integer_headers_2 into 6a8d0d6 on urschrei:dev.

@urschrei urschrei merged commit aa537d7 into urschrei:dev Aug 23, 2016
@urschrei
Copy link
Owner

Merged and released to PyPI as v1.1.19, which should fix subsequent zotero-cli installs. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coveralls @urschrei