-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/82: Migrate the build tool from maven to gradle #83
Conversation
As suggested by the build scan
…mato-common-entity
I really like this approach, it's much more concise. However, I did not get it to work. The files in Thanks for the spike review! I pushed the change that fixes running scipamato-core, by the way. |
Arf, Indeed. My proposed change does not seem possible. The It prevents a lot of possible abstraction for applying the plugins. I'll have to play more with it to figure out what's the best solution. |
119c0dd
to
b279023
Compare
* ignore jooq and jaxb generated classes
* code coverage is passed on to sonarcloud, but still, we don't see coverage for classes that are tested in other modules (e.g. AbstractDefinitionEntity (in common/entity) that is tested by AbstractDefinitionEntityTest (in common/test).
…ith maven * Suspecting that integration test coverage is not included... Need to investigate * Also tried using the binary exec format instead of the xml report, to no avail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks nice to me.
The build seems almost simple compared to the complexity of the project, so I'd call that a success.
It worked also well for me (I tried the tasks check
, :core-web:bootRun
and :public-web:bootRun
)
@jcornaz Many thanks for your review! |
Resolves #82