New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING CHANGE] Refactoring: Split event loop in several modules #537
Conversation
* `urwid.main_loop` is split into multiple modules which is easier to maintain * `urwid.compat` is not used anymore and removed * `TornadoEventLoop`, `GLibEventLoop`, `TwistedEventLoop` and `TrioEventLoop` accessible ONLY if required dependencies installed (like: Tornado installed -> `TornadoEventLoop` is accessible for import) * `TornadoEventLoop` use the same idle logic as `AsyncioLoop`: tornado.ioloop.IOLoop is asyncio based. * Trio < 0.15 is not supported. Version 0.15 was released almost 3 years ago. * Tornado < 5.0 is not supported. Tornado 5.0 was released 5 years ago.
What's the breaking change part of this? It looks like the |
Direct import of event loop class from implementation module changed (since module splitted). |
* `EventLoop` should be real abstract * add new module docstrings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
urwid.main_loop
is split into multiple modules which is easier to maintainurwid.compat
is not used anymore and removedTornadoEventLoop
,GLibEventLoop
,TwistedEventLoop
andTrioEventLoop
accessible ONLY if required dependencies installed (like: Tornado installed ->TornadoEventLoop
is accessible for import)TornadoEventLoop
use the same idle logic asAsyncioLoop
: tornado.ioloop.IOLoop is asyncio based.Checklist
master
orpython-dual-support
branchtox
successfully in local environment