Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 256 color and truecolor support to vterm. Fixes #457 #559

Merged
merged 2 commits into from Jun 2, 2023
Merged

Adds 256 color and truecolor support to vterm. Fixes #457 #559

merged 2 commits into from Jun 2, 2023

Conversation

danschwarz
Copy link
Contributor

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment [Python 3.x only; can't run 2.7 locally]
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)
Description:

Adds high color support to vterm.py - 88 color, 256 color, truecolor modes.
Monochrome and 16 color mode work as before.

What's missing/needed:
Testing against Python 2.7 - my Ubuntu 22.04 dev box complains when running 2.7, which causes tox to fail.
Add tox tests if it's possible to verify correct color output using tox tests?

Here is palette_test.py running in terminal.py:
image

Copy link
Collaborator

@penguinolog penguinolog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix attr 39 parsing and LGTM

urwid/vterm.py Show resolved Hide resolved
urwid/vterm.py Outdated Show resolved Hide resolved
@penguinolog
Copy link
Collaborator

I will run tests against dependent projects in few hours and merge on success

@penguinolog penguinolog merged commit ee3498a into urwid:master Jun 2, 2023
5 checks passed
@penguinolog
Copy link
Collaborator

khal tests pass
zulip-terminal tests pass

@danschwarz danschwarz deleted the vterm_hicolor2 branch June 2, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants