Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vterm: Fixed a crash bug with DECALN command #560

Merged
merged 1 commit into from Jun 3, 2023
Merged

vterm: Fixed a crash bug with DECALN command #560

merged 1 commit into from Jun 3, 2023

Conversation

danschwarz
Copy link
Contributor

@danschwarz danschwarz commented Jun 2, 2023

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)
Description:

vterm.py was crashing upon execution of DECALN (ESC # 8) because the code was sending a string to empty_line which requires a byte. This prevented vttest from running many test cases.

to test this, run terminal.py and execute the following shell command:

echo -e "\033#8"

Without this fix, urwid crashes. With the fix, you'll see a lot of Es onscreen, as expected. No crash.

@danschwarz danschwarz changed the title Fixed a crash bug with vterm.py DECALN command vterm: Fixed a crash bug with DECALN command Jun 2, 2023
@penguinolog penguinolog merged commit 3c21a42 into urwid:master Jun 3, 2023
5 checks passed
@danschwarz danschwarz deleted the vterm_decaln_fix branch June 3, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants