Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #583: python 3.12 compatibility #598

Merged
merged 2 commits into from Sep 4, 2023
Merged

Fix #583: python 3.12 compatibility #598

merged 2 commits into from Sep 4, 2023

Conversation

penguinolog
Copy link
Collaborator

Replace as pep-0393 recommended:

  • PyUnicode_AS_UNICODE by PyUnicode_ReadChar (use Stable API)

  • Enable PR tests on python 3.12

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

Fix urwid#583: python 3.12 compatibility
8fc71b5 
Replace as pep-0393 recommended:

* `PyUnicode_AS_UNICODE` by `PyUnicode_ReadChar`
  (use Stable API)

* Enable PR tests on python 3.12
@penguinolog penguinolog added bug Unicode Issues related to Unicode <-> bytes conversion labels Sep 4, 2023
@penguinolog penguinolog linked an issue Sep 4, 2023 that may be closed by this pull request
Python 3.12: PyUnicode_AS_UNICODE has been removed #583
Closed
3 tasks
@penguinolog penguinolog merged commit 44f46f9 into urwid:master Sep 4, 2023
21 checks passed
@penguinolog penguinolog deleted the fix_py312 branch September 4, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardi wardi wardi approved these changes

@rayburgemeestre rayburgemeestre rayburgemeestre approved these changes

@eantoranz eantoranz eantoranz approved these changes

Assignees
No one assigned
Labels
bug Unicode Issues related to Unicode <-> bytes conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.12: PyUnicode_AS_UNICODE has been removed
4 participants
@penguinolog @wardi @rayburgemeestre @eantoranz