Skip to content

Fix #583: python 3.12 compatibility#598

Merged
penguinolog merged 2 commits into
urwid:masterfrom
penguinolog:fix_py312
Sep 4, 2023
Merged

Fix #583: python 3.12 compatibility#598
penguinolog merged 2 commits into
urwid:masterfrom
penguinolog:fix_py312

Conversation

@penguinolog

Copy link
Copy Markdown
Collaborator

Replace as pep-0393 recommended:

  • PyUnicode_AS_UNICODE by PyUnicode_ReadChar (use Stable API)

  • Enable PR tests on python 3.12

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

Replace as pep-0393 recommended:

* `PyUnicode_AS_UNICODE` by `PyUnicode_ReadChar`
  (use Stable API)

* Enable PR tests on python 3.12
@penguinolog penguinolog added bug Unicode Issues related to Unicode <-> bytes conversion labels Sep 4, 2023
@penguinolog penguinolog requested a review from wardi September 4, 2023 09:33
@penguinolog penguinolog linked an issue Sep 4, 2023 that may be closed by this pull request
3 tasks
@penguinolog penguinolog merged commit 44f46f9 into urwid:master Sep 4, 2023
@penguinolog penguinolog deleted the fix_py312 branch September 4, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unicode Issues related to Unicode <-> bytes conversion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.12: PyUnicode_AS_UNICODE has been removed

4 participants