Skip to content

Feature: Support pack() for CheckBox/RadioButton/Button - #621

Merged
penguinolog merged 2 commits into
urwid:masterfrom
penguinolog:feature_wimp_pack
Sep 25, 2023
Merged

penguinolog merged 2 commits into
urwid:masterfrom
penguinolog:feature_wimp_pack

Conversation

@penguinolog

Copy link
Copy Markdown
Collaborator

Partial #421

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

@penguinolog penguinolog added the Feature Feature request/implementation label Sep 25, 2023
@penguinolog
penguinolog requested a review from wardi September 25, 2023 09:20
@coveralls

coveralls commented Sep 25, 2023 •

Copy link
Copy Markdown

Coverage Status

coverage: 74.311% (+0.7%) from 73.566% when pulling ae2926e on penguinolog:feature_wimp_pack into b70be02 on urwid:master.

@wardi wardi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok, but maybe add a comment in the constructor that the pack method below assumes the wrapped widget won't change.

Possibly better would be to implement pack in Columns so that we don't have to define it here, don't need special warnings in the code and make it useful in more cases.

@penguinolog
penguinolog merged commit 97b3d6d into urwid:master Sep 25, 2023
@penguinolog
penguinolog deleted the feature_wimp_pack branch September 25, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Feature request/implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants