Refactoring numedit: PEP8 arguments, allow negative, type casts

[penguinolog]

• USE PEP8 compliant arguments and deprecate old one
• Allow cast IntEdit to int and FloatEdit to float
• Allow negative values without changing default behavior

Fix: #603
Fix: #432
Partial: #502

Checklist

• I've ensured that similar functionality has not already been implemented
• I've ensured that similar functionality has not earlier been proposed and declined
• I've branched off the master or python-dual-support branch
• I've merged fresh upstream into my branch recently
• I've ran tox successfully in local environment
• I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

[coveralls]

Pull Request Test Coverage Report for Build 6310809682

• 38 of 41 (92.68%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.04%) to 74.347%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
urwid/numedit.py	36	39	92.31%

Totals
Change from base Build 6309279069:	0.04%
Covered Lines:	7528
Relevant Lines:	10255

---

💛 - Coveralls

[penguinolog]

Old arguments not changing order, not forcing position, just defaults changed to `None` New arguments are enforcing keyword only and overridden by old if old is not None. Op di 26 sep. 2023 14:25 schreef Jason C ***@***.***>:

…

***@***.**** commented on this pull request. ------------------------------ In urwid/numedit.py <#636 (comment)>: > + preserveSignificance: bool | None = None, + decimalSeparator: str | None = None, + *, + preserve_significance: bool = True, + decimal_separator: str = ".", + allow_negative: bool = False, This appears to be a breaking change to code that used to use preserveSignificance and decimalSeparator as a keyword arg. The following changes should probably be made to preserve compatibility: - Keep preserveSignificance defaulted to True - Have preserve_significance default to None - Assign preserve_significance = preserveSignificance if preserve_significance == None And the same for decimalSeparator. Otherwise, from the code, it looks like the value of preserveSignificance is ignored, which is the breaking part. Either that or just leave it be and accept that the case doesn't fit the normal style. — Reply to this email directly, view it on GitHub <#636 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD2KMMZ22Y5FOOGOJLKAIQLX4LCTFANCNFSM6AAAAAA5HMZHUU> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[JC3]

Yeah I see. I realized what was happening right after I made the comment and immediately deleted it. Sorry about that! Change looks good! 😀

…

On Tue, Sep 26, 2023, 8:43 AM Alexey Stepanov ***@***.***> wrote: Old arguments not changing order, not forcing position, just defaults changed to `None` New arguments are enforcing keyword only and overridden by old if old is not None. Op di 26 sep. 2023 14:25 schreef Jason C ***@***.***>: > ***@***.**** commented on this pull request. > ------------------------------ > > In urwid/numedit.py > <#636 (comment)>: > > > + preserveSignificance: bool | None = None, > + decimalSeparator: str | None = None, > + *, > + preserve_significance: bool = True, > + decimal_separator: str = ".", > + allow_negative: bool = False, > > This appears to be a breaking change to code that used to use > preserveSignificance and decimalSeparator as a keyword arg. The following > changes should probably be made to preserve compatibility: > > - Keep preserveSignificance defaulted to True > - Have preserve_significance default to None > - Assign preserve_significance = preserveSignificance if preserve_significance > == None > > And the same for decimalSeparator. > > Otherwise, from the code, it looks like the value of preserveSignificance > is ignored, which is the breaking part. > > Either that or just leave it be and accept that the case doesn't fit the > normal style. > > — > Reply to this email directly, view it on GitHub > <#636 (review)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AD2KMMZ22Y5FOOGOJLKAIQLX4LCTFANCNFSM6AAAAAA5HMZHUU> > . > You are receiving this because you modified the open/close state.Message > ID: ***@***.***> > — Reply to this email directly, view it on GitHub <#636 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLDV4AW7QUCWT3RVOID6F3X4LEXPANCNFSM6AAAAAA5HMZHUU> . You are receiving this because you commented.Message ID: ***@***.***>