Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception re-raise in trio event loop #683

Merged
merged 1 commit into from Nov 27, 2023

Conversation

penguinolog
Copy link
Collaborator

  • restore traceback
Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

@@ -218,7 +218,7 @@ def _handle_main_loop_exception(self, exc: BaseException) -> None:
if isinstance(exc, ExitMainLoop):
return

raise exc
raise exc.with_traceback(exc.__traceback__) from None
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

force re-use traceback instead of rewrite
intercept context from exception group

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7010229039

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.161%

Totals Coverage Status
Change from base Build 7003143499: 0.0%
Covered Lines: 7517
Relevant Lines: 10280

💛 - Coveralls

@penguinolog penguinolog merged commit e9e33b3 into urwid:master Nov 27, 2023
23 checks passed
@penguinolog penguinolog deleted the fix_rerais branch November 27, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants