Skip to content

Maintenance: Tests: Use explicit encoding for tests#685

Merged
penguinolog merged 1 commit intourwid:masterfrom
penguinolog:tests_explicit_encoding
Nov 30, 2023
Merged

Maintenance: Tests: Use explicit encoding for tests#685
penguinolog merged 1 commit intourwid:masterfrom
penguinolog:tests_explicit_encoding

Conversation

@penguinolog
Copy link
Collaborator

  • Tests with render can fail if detected encoding differs from used during test write

  • add non-public api for internal testing: util.get_encoding() for public getting _target_encoding util.set_temporary_encoding context manager

  • Extend "Canvas text is wider than the maxcol specified" details: reproduced on nonstandard encoding

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

* Tests with `render` can fail
  if detected encoding differs
  from used during test write

* add non-public api for internal testing:
  `util.get_encoding()` for public getting _target_encoding
  `util.set_temporary_encoding` context manager

* Extend "Canvas text is wider than the maxcol specified" details:
  reproduced on nonstandard encoding
@penguinolog penguinolog added the Tests Tests label Nov 28, 2023
@penguinolog penguinolog requested a review from ulidtko November 28, 2023 08:23
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7016026786

  • 9 of 10 (90.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 74.242%

Changes Missing Coverage Covered Lines Changed/Added Lines %
urwid/canvas.py 0 1 0.0%
Totals Coverage Status
Change from base Build 7015514000: 0.08%
Covered Lines: 7526
Relevant Lines: 10289

💛 - Coveralls

@penguinolog penguinolog requested a review from wardi November 28, 2023 08:26
@penguinolog penguinolog merged commit 45ab61f into urwid:master Nov 30, 2023
@penguinolog penguinolog deleted the tests_explicit_encoding branch November 30, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tests Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants