Feature: Implement keypress and mouse_event default handlers - #721
Merged
Conversation
* `Widget` class to have default standard handlers * Produce debug log for non-selectable widgets received events * Produce `WidgetWarning` if `__init__` of base class not called * Produce deprecation warnings if no subclassed Widget
Collaborator
Author
|
This PR should be used instead of #718 : do not break existing code |
Pull Request Test Coverage Report for Build 7388485737
💛 - Coveralls |
Collaborator
|
should also update docs if subclassing Widget will be required |
Collaborator
Author
https://github.com/urwid/urwid/blob/master/docs/manual/widgets.rst?plain=1#L656 It is already in documentation for the last 11 years |
Collaborator
Author
|
Validated
(Source is not urwid side) |
Collaborator
Author
|
Validated |
wardi
reviewed
Jan 2, 2024
wardi
reviewed
Jan 2, 2024
Co-authored-by: Ian Ward <ian@excess.org>
Co-authored-by: Ian Ward <ian@excess.org>
wardi
reviewed
Jan 2, 2024
wardi
approved these changes
Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widgetclass to have default standard handlersWidgetWarningif__init__of base class not calledChecklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment