Feature: Support FIXED and FLOW operations for Overlay depends on options
#743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptions * Add tests * Update documentation
penguinolog
commented
Jan 12, 2024
There was a problem hiding this comment.
File will be re-generated from original vectors in another PR
penguinolog
commented
Jan 12, 2024
| @@ -304,17 +304,17 @@ new space. | |||
| Overlay Widgets | |||
| --------------- | |||
|
|
|||
| The :class:`Overlay` widget is a box widget that contains two | |||
| other box widgets. The bottom widget is rendered the full size of the Overlay | |||
There was a problem hiding this comment.
looks like totally outdated
Pull Request Test Coverage Report for Build 7505379911
💛 - Coveralls |
penguinolog
commented
Jan 12, 2024
| * * width amount and GIVEN width or min_width AND: | ||
| * * * FLOW supported by the TOP widget AND PACK height type | ||
| * * * BOX supported by the TOP widget AND height_amount and GIVEN height or min height | ||
| """ |
There was a problem hiding this comment.
IMHO adding examples is overkill (too complex arguments sequences)
penguinolog
commented
Jan 12, 2024
| if Sizing.FIXED in top_sizing: | ||
| sizing.add(Sizing.FIXED) | ||
| else: | ||
| warnings.warn( |
There was a problem hiding this comment.
negative cases with warnings and exceptions should be covered separately.
Provide information about owner widget
penguinolog
commented
Jan 12, 2024
| def __rich_repr__(inner_self) -> Iterator[tuple[str | None, typing.Any] | typing.Any]: | ||
| yield from self.items() | ||
| yield from inner_self.items() |
There was a problem hiding this comment.
Autocomplete fail
|
|
||
| if typing.TYPE_CHECKING: | ||
| from collections.abc import Iterator | ||
|
|
||
| from typing_extensions import Literal | ||
|
|
||
|
|
||
| class OverlayError(Exception): | ||
| pass | ||
| class OverlayError(WidgetError): |
There was a problem hiding this comment.
Proper exception class (need to do for others widgets too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment