LineBox: make side only if side elements present, fix pack #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* BUG: `LineBox().pack` was ignored nonexistent top/bottom. Switch to the backend (Pile) `pack` usage to get proper size * Semi-bug: in case of no side, empty elements was partially added (top and bottom) with fixed size == 1 (Bug urwid#337) * For consistency add right corner with width=0 if no right corner * Propagate default empty size for `pack` if widgets are optionally FIXED No size will be handled internally
Pull Request Test Coverage Report for Build 7543080965
💛 - Coveralls |
wardi
reviewed
Jan 16, 2024
tests/test_line_box.py
Outdated
| pressed = False | ||
|
|
||
| with self.subTest("No left side elements -> no side"): | ||
| l = urwid.LineBox(wrapped, tlcorner="", lline="", blcorner="") |
There was a problem hiding this comment.
do we need to remove corners when lline is empty?
There was a problem hiding this comment.
I mean it would be a nicer interface if we didn't, like with top and bottom
There was a problem hiding this comment.
We can add it to make consistent with top and bottom
wardi
approved these changes
Jan 16, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LineBox().packwas ignored nonexistent top/bottom. Switch to the backend (Pile)packusage to get proper sizeset_titlewithout title was not properly checked for top widget availability and caused exceptionpackif widgets are optionally FIXED No size will be handled internallyFix #337
Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment